Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit initialization of PYTHONPATH with workspace for dbg test #1576

Merged
merged 3 commits into from
May 7, 2018

Conversation

DonJayamanne
Copy link

Fixes #1465

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I've added a single 'Nit' that you can feel free to ignore.

@@ -38,7 +38,7 @@ suite(`Module Debugging - Misc tests: ${debuggerType}`, () => {
function buildLauncArgs(): LaunchRequestArguments {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important at all, but can we fix the typo in this function name while we are at it, or will that break stuff?

buildLaunc_h_Args

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make a constant for the env['PYTHONPATH'] to lose the tslint-disable line?

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #1576 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
- Coverage   71.65%   71.42%   -0.23%     
==========================================
  Files         273      273              
  Lines       12700    12700              
  Branches     2282     2282              
==========================================
- Hits         9100     9071      -29     
- Misses       3465     3494      +29     
  Partials      135      135
Impacted Files Coverage Δ
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
src/client/linters/baseLinter.ts 88.54% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5127486...af976ad. Read the comment docs.

@DonJayamanne DonJayamanne merged commit fffa444 into microsoft:master May 7, 2018
@DonJayamanne DonJayamanne deleted the issue1465 branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to debug a module with the experimental debugger
2 participants