Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue that causes linter to fail when file path contains spaces. #1241

Merged
merged 5 commits into from
Mar 29, 2018
Merged

Fixes issue that causes linter to fail when file path contains spaces. #1241

merged 5 commits into from
Mar 29, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 29, 2018 •
edited by brettcannon
Loading

Fixes #1239

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@brettcannon brettcannon merged commit 9cb760a into microsoft:release-2018.3 Mar 29, 2018
brettcannon pushed a commit to brettcannon/vscode-python that referenced this pull request Mar 29, 2018
@DonJayamanne @brettcannon
Fixes issue that causes linter to fail when file path contains spaces. (
d9972d4 
microsoft#1241)
DonJayamanne pushed a commit that referenced this pull request Mar 30, 2018
@brettcannon @DonJayamanne
Fixes issue that causes linter to fail when file path contains spaces. (
7823c7b 
#1241) (#1243)

Forward-port from 2018.3.1
Fixes #1239
@DonJayamanne DonJayamanne deleted the fixUnnecessaryFileQuotes branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @brettcannon