Disable the display of errors messages when rediscovering of tests fail in response to changes to files #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
==========================================
+ Coverage 71.81% 71.86% +0.05%
==========================================
Files 260 260
Lines 11898 11898
Branches 2112 2112
==========================================
+ Hits 8545 8551 +6
+ Misses 3226 3223 -3
+ Partials 127 124 -3
Continue to review full report at Codecov.
|
|
@brettcannon ping |
brettcannon
approved these changes
Mar 22, 2018
news/1 Enhancements/704.md
Outdated
| @@ -0,0 +1 @@ | |||
| Disable the display of errors messages when rediscovering of tests fail in response to changes to files. | |||
There was a problem hiding this comment.
"to files, e.g. don't show a message if there's a syntax error in the test code."
| const discoveryPromise = testManager.discoverTests(cmdSource, ignoreCache, false, userInitiated); | ||
| testResultDisplay.displayDiscoverStatus(discoveryPromise) | ||
| testResultDisplay = testResultDisplay ? testResultDisplay : new TestResultDisplay(onDidChange); | ||
| const discoveryPromise = testManager.discoverTests(cmdSource, ignoreCache, quietMode, userInitiated); |
There was a problem hiding this comment.
I don't see a change to this API, so I assume this is what false used to represent?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #704
@brettcannon
This pull request: