Add missing operators in tokenizer, handle end-of-comment completion better #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 1, 2017 10:18
DonJayamanne
requested changes
Mar 20, 2018
| if (index >= 0) { | ||
| const token = tokens.getItemAt(index); | ||
| if (token.end === offset) { | ||
| if (token.type === TokenType.Comment) { |
There was a problem hiding this comment.
if (token.end === offset && token.type === TokenType.Comment) {
DonJayamanne
approved these changes
Mar 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 71.79% 71.89% +0.09%
==========================================
Files 260 260
Lines 11892 11898 +6
Branches 2107 2112 +5
==========================================
+ Hits 8538 8554 +16
+ Misses 3225 3220 -5
+ Partials 129 124 -5
Continue to review full report at Codecov.
|
|
@MikhailArkhipov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096
Fixes #1123
=>and<=to operators in tokenizer + test