Code navigation should support self navigating to the class defintion

[jarshwah]

Environment data

• VS Code version: 1.23.0
• Extension version (available under the Extensions sidebar): 2018.04
• OS and version: OSX 10.13.4
• Python version (& distribution if applicable, e.g. Anaconda): pyenv 2.7 - 3.6
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv

Actual behavior

When command clicking on the self argument of a method, the code does not navigate anywhere. CMD+Hover over self will show the current method in the preview window.

Expected behavior

(Wanted behaviour rather than expected)

When CMD+Click on the self argument to a method, the cursor should navigate to the class definition. When CMD+Hover over the self argument, the class definition should be shown in the preview window.

This will help with very long class definitions where many classes exist in the same file, such as some django projects having large models.py files (an anti-pattern, but one in very wide use).

Otherwise, a "simple" way to navigate to the current class definition would be nearly as good.

[hmleal]

👍

[brettcannon]

@hmleal we track feature requests by reaction upvotes, so please do that if you would like your vote to be counted.

[hmleal]

@brettcannon Thanks ;)

[MikhailArkhipov]

@jarshwah - is this something you expect

and go to def on any self goes to the respective class definition - not just when it is function argument.

[jarshwah]

Yes, that’d be extremely useful!

…

On Sat, 13 Oct 2018 at 04:49, Mikhail Arkhipov ***@***.***> wrote: @jarshwah <https://github.com/jarshwah> - is this something you expect [image: image] <https://user-images.githubusercontent.com/12820357/46885249-4d808d80-ce0c-11e8-81a2-177d6794ec06.png> and go to def on any self goes to the respective class definition - not just when it is function argument. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1637 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhBm6oGkK33ubbdWrYbkYqQkwwS5xTLks5ukNYmgaJpZM4T2DRW> .

[MikhailArkhipov]

OK, that is the way I implemented it. :-)

[jarshwah]

@MikhailArkhipov this is done in upstream, no? Can we then close off this issue?

[brettcannon]

@jarshwah yep, I just verified this is available publicly.