conditionally import reflect-metadata and fix run without debug (#455)

* Conditionally import `reflect-metadata` (fixes #432)
    * Once within the extension  
    * Once within the debugger  
    * Once within the unittests  
* Fully qualify the `path` module (fixes #454)

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Version 0.9.1 (18 December 2017)
+
+* Fixes the compatibility issue with the [Visual Studio Code Tools for AI
+](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.vscode-ai) extension by conditionally importing `reflect-metadata` [#432](https://github.com/Microsoft/vscode-python/issues/432)
+* Display runtime errors encountered when running a python program without debugging [#454](https://github.com/Microsoft/vscode-python/issues/454)
+
 ## Version 0.9.0 (14 December 2017)
 
 * Translated the commands to simplified Chinese [#240](https://github.com/Microsoft/vscode-python/pull/240) (thanks [Wai Sui kei](https://github.com/WaiSiuKei))

package.json

@@ -2,7 +2,7 @@
 	"name": "python",
 	"displayName": "Python",
 	"description": "Linting, Debugging (multi-threaded, remote), Intellisense, code formatting, refactoring, unit tests, snippets, and more.",
-	"version": "0.9.0",
+	"version": "0.9.1",
 	"publisher": "ms-python",
 	"author": {
 		"name": "Microsoft Corporation"

pythonFiles/PythonTools/visualstudio_py_launcher_nodebug.py

@@ -114,7 +114,7 @@ def handle_exception(exc_type, exc_value, exc_tb):
     tb = traceback.extract_tb(exc_tb)
     for i in [0, -1]:
         while tb:
-            frame_file = path.normcase(tb[i][0])
+            frame_file = os.path.normcase(tb[i][0])
             if not any(is_same_py_file(frame_file, f) for f in do_not_debug):
                 break
             del tb[i]

src/client/common/envFileParser.ts

@@ -1,5 +1,4 @@
 import * as fs from 'fs-extra';
-import 'reflect-metadata';
 import { PathUtils } from './platform/pathUtils';
 import { EnvironmentVariablesService } from './variables/environment';
 import { EnvironmentVariables } from './variables/types';

src/client/common/installer/condaInstaller.ts

@@ -3,7 +3,6 @@
 
 import { inject, injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { ICondaLocatorService, IInterpreterLocatorService, INTERPRETER_LOCATOR_SERVICE, InterpreterType } from '../../interpreter/contracts';
 import { CONDA_RELATIVE_PY_PATH } from '../../interpreter/locators/services/conda';

src/client/common/installer/installer.ts

@@ -1,7 +1,6 @@
 import { inject, injectable, named } from 'inversify';
 import * as os from 'os';
 import * as path from 'path';
-import 'reflect-metadata';
 import { ConfigurationTarget, QuickPickItem, Uri, window, workspace } from 'vscode';
 import * as vscode from 'vscode';
 import { IFormatterHelper } from '../../formatters/types';

src/client/common/installer/moduleInstaller.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { IServiceContainer } from '../../ioc/types';
 import { PythonSettings } from '../configSettings';

src/client/common/installer/pipInstaller.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Uri, workspace } from 'vscode';
 import { IServiceContainer } from '../../ioc/types';
 import { IPythonExecutionFactory } from '../process/types';

src/client/common/logger.ts

@@ -1,5 +1,4 @@
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { ILogger } from './types';
 
 const PREFIX = 'Python Extension: ';

src/client/common/persistentState.ts

@@ -4,7 +4,6 @@
 'use strict';
 
 import { inject, injectable, named } from 'inversify';
-import 'reflect-metadata';
 import { Memento } from 'vscode';
 import { GLOBAL_MEMENTO, IMemento, IPersistentState, IPersistentStateFactory, WORKSPACE_MEMENTO } from './types';
 

src/client/common/platform/pathUtils.ts

@@ -1,5 +1,4 @@
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { IPathUtils, IsWindows } from '../types';
 import { NON_WINDOWS_PATH_VARIABLE_NAME, WINDOWS_PATH_VARIABLE_NAME } from './constants';
 

src/client/common/platform/registry.ts

@@ -1,5 +1,4 @@
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import * as Registry from 'winreg';
 import { Architecture, IRegistry, RegistryHive } from './types';
 

src/client/common/process/decoder.ts

@@ -3,7 +3,6 @@
 
 import * as iconv from 'iconv-lite';
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { DEFAULT_ENCODING } from './constants';
 import { IBufferDecoder } from './types';
 

src/client/common/process/proc.ts

@@ -3,7 +3,6 @@
 
 import { spawn } from 'child_process';
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import * as Rx from 'rxjs';
 import { Disposable } from 'vscode';
 import { createDeferred } from '../helpers';

src/client/common/process/pythonExecutionFactory.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { PythonSettings } from '../configSettings';
 import { IEnvironmentVariablesProvider } from '../variables/types';

src/client/common/process/pythonProcess.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { ErrorUtils } from '../errors/errorUtils';
 import { ModuleNotInstalledError } from '../errors/moduleNotInstalledError';
 import { EnvironmentVariables } from '../variables/types';

src/client/common/process/serviceRegistry.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-// tslint:disable-next-line:no-import-side-effect
-import 'reflect-metadata';
 import { IServiceManager } from '../../ioc/types';
 import { BufferDecoder } from './decoder';
 import { ProcessService } from './proc';

src/client/common/serviceRegistry.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import 'reflect-metadata';
 import { IServiceManager } from '../ioc/types';
 import { CondaInstaller } from './installer/condaInstaller';
 import { Installer } from './installer/installer';

src/client/common/terminal/service.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Disposable, Terminal, Uri, window, workspace } from 'vscode';
 import { IServiceContainer } from '../../ioc/types';
 import { IDisposableRegistry, IsWindows } from '../types';

src/client/common/variables/environment.ts

@@ -4,7 +4,6 @@
 import * as fs from 'fs-extra';
 import { inject, injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { IPathUtils } from '../types';
 import { EnvironmentVariables, IEnvironmentVariablesService } from './types';
 

src/client/common/variables/environmentVariablesProvider.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Disposable, FileSystemWatcher, Uri, workspace } from 'vscode';
 import { PythonSettings } from '../configSettings';
 import { NON_WINDOWS_PATH_VARIABLE_NAME, WINDOWS_PATH_VARIABLE_NAME } from '../platform/constants';

src/client/common/variables/serviceRegistry.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-// tslint:disable-next-line:no-import-side-effect
-import 'reflect-metadata';
 import { IServiceManager } from '../../ioc/types';
 import { EnvironmentVariablesService } from './environment';
 import { EnvironmentVariablesProvider } from './environmentVariablesProvider';

src/client/debugger/Main.ts

@@ -1,8 +1,12 @@
 "use strict";
 
+// This line should always be right on top.
+if (Reflect.metadata === undefined) {
+    // tslint:disable-next-line:no-require-imports no-var-requires
+    require('reflect-metadata');
+}
 import * as fs from "fs";
 import * as path from "path";
-import 'reflect-metadata';
 import { DebugSession, Handles, InitializedEvent, OutputEvent, Scope, Source, StackFrame, StoppedEvent, TerminatedEvent, Thread } from "vscode-debugadapter";
 import { ThreadEvent } from "vscode-debugadapter";
 import { DebugProtocol } from "vscode-debugprotocol";

src/client/extension.ts

@@ -1,4 +1,9 @@
 'use strict';
+// This line should always be right on top.
+if (Reflect.metadata === undefined) {
+    // tslint:disable-next-line:no-require-imports no-var-requires
+    require('reflect-metadata');
+}
 import { Container } from 'inversify';
 import * as os from 'os';
 import * as vscode from 'vscode';

src/client/formatters/helper.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { IFormattingSettings } from '../common/configSettings';
 import { Product } from '../common/types';
 import { FormatterId, FormatterSettingsPropertyNames, IFormatterHelper } from './types';

src/client/formatters/serviceRegistry.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import 'reflect-metadata';
 import { IServiceManager } from '../ioc/types';
 import { FormatterHelper } from './helper';
 import { IFormatterHelper } from './types';

src/client/interpreter/interpreterVersion.ts

@@ -1,6 +1,5 @@
 import * as child_process from 'child_process';
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { getInterpreterVersion } from '../common/utils';
 import { IInterpreterVersionService } from './contracts';
 

src/client/interpreter/locators/services/KnownPathsService.ts

@@ -1,7 +1,6 @@
 import { inject, injectable } from 'inversify';
 import * as _ from 'lodash';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { fsExistsAsync, IS_WINDOWS } from '../../../common/utils';
 import { IInterpreterLocatorService, IInterpreterVersionService, IKnownSearchPathsForInterpreters, InterpreterType } from '../../contracts';

src/client/interpreter/locators/services/condaEnvFileService.ts

@@ -1,7 +1,6 @@
 import * as fs from 'fs-extra';
 import { inject, injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { IS_WINDOWS } from '../../../common/configSettings';
 import {

src/client/interpreter/locators/services/condaEnvService.ts

@@ -2,7 +2,6 @@ import * as child_process from 'child_process';
 import * as fs from 'fs-extra';
 import { inject, injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { VersionUtils } from '../../../common/versionUtils';
 import { ICondaLocatorService, IInterpreterLocatorService, IInterpreterVersionService, InterpreterType, PythonInterpreter } from '../../contracts';

src/client/interpreter/locators/services/condaLocator.ts

@@ -2,7 +2,6 @@ import * as child_process from 'child_process';
 import * as fs from 'fs-extra';
 import { inject, injectable, named, optional } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { IProcessService } from '../../../common/process/types';
 import { IsWindows } from '../../../common/types';
 import { VersionUtils } from '../../../common/versionUtils';

src/client/interpreter/locators/services/currentPathService.ts

@@ -2,7 +2,6 @@ import * as child_process from 'child_process';
 import { inject, injectable } from 'inversify';
 import * as _ from 'lodash';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { PythonSettings } from '../../../common/configSettings';
 import { IInterpreterLocatorService, IInterpreterVersionService, InterpreterType } from '../../contracts';

src/client/interpreter/locators/services/virtualEnvService.ts

@@ -1,7 +1,6 @@
 import { inject, injectable } from 'inversify';
 import * as _ from 'lodash';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri, workspace } from 'vscode';
 import { fsReaddirAsync, IS_WINDOWS } from '../../../common/utils';
 import { IInterpreterLocatorService, IInterpreterVersionService, IKnownSearchPathsForVirtualEnvironments, InterpreterType, PythonInterpreter } from '../../contracts';

src/client/interpreter/serviceRegistry.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import 'reflect-metadata';
 import { IsWindows } from '../common/types';
 import { IServiceManager } from '../ioc/types';
 import {

src/client/interpreter/virtualEnvs/venv.ts

@@ -1,6 +1,5 @@
 import { injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { fsExistsAsync } from '../../common/utils';
 import { InterpreterType } from '../contracts';
 import { IVirtualEnvironmentIdentifier } from './types';

src/client/interpreter/virtualEnvs/virtualEnv.ts

@@ -1,6 +1,5 @@
 import { injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { fsExistsAsync } from '../../common/utils';
 import { InterpreterType } from '../contracts';
 import { IVirtualEnvironmentIdentifier } from './types';

src/client/linters/helper.ts

@@ -1,6 +1,5 @@
 import { injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { ILintingSettings, PythonSettings } from '../common/configSettings';
 import { ExecutionInfo, Product } from '../common/types';

src/client/linters/serviceRegistry.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-import 'reflect-metadata';
 import { IServiceManager } from '../ioc/types';
 import { LinterHelper } from './helper';
 import { ILinterHelper } from './types';

src/client/unittests/common/debugLauncher.ts

@@ -1,7 +1,6 @@
 import * as getFreePort from 'get-port';
 import { inject, injectable } from 'inversify';
 import * as os from 'os';
-import 'reflect-metadata';
 import { debug, Uri, workspace } from 'vscode';
 import { PythonSettings } from '../../common/configSettings';
 import { IPythonExecutionFactory } from '../../common/process/types';

src/client/unittests/common/services/storageService.ts

@@ -1,5 +1,4 @@
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Disposable, Uri, workspace } from 'vscode';
 import { IDisposableRegistry } from '../../../common/types';
 import { ITestCollectionStorageService, Tests } from './../types';

src/client/unittests/common/services/testResultsService.ts

@@ -1,5 +1,4 @@
 import { inject, injectable, named } from 'inversify';
-import 'reflect-metadata';
 import { TestResultResetVisitor } from './../testVisitors/resultResetVisitor';
 import { ITestResultsService, ITestVisitor, TestFile, TestFolder, Tests, TestStatus, TestSuite } from './../types';
 

src/client/unittests/common/services/workspaceTestManagerService.ts

@@ -1,5 +1,4 @@
 import { inject, injectable, named } from 'inversify';
-import 'reflect-metadata';
 import { Disposable, OutputChannel, Uri, workspace } from 'vscode';
 import { IDisposableRegistry, IOutputChannel } from '../../../common/types';
 import { TEST_OUTPUT_CHANNEL } from './../constants';

src/client/unittests/common/testUtils.ts

@@ -1,6 +1,5 @@
 import { inject, injectable, named } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import * as vscode from 'vscode';
 import { Uri, workspace } from 'vscode';
 import { window } from 'vscode';

src/client/unittests/common/testVisitors/flatteningVisitor.ts

@@ -1,5 +1,4 @@
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { convertFileToPackage } from '../testUtils';
 import {
     FlattenedTestFunction,

src/client/unittests/common/testVisitors/folderGenerationVisitor.ts

@@ -1,6 +1,5 @@
 import { injectable } from 'inversify';
 import * as path from 'path';
-import 'reflect-metadata';
 import { ITestVisitor, TestFile, TestFolder, TestFunction, TestSuite } from '../types';
 
 @injectable()

src/client/unittests/common/testVisitors/resultResetVisitor.ts

@@ -1,5 +1,4 @@
 import { injectable } from 'inversify';
-import 'reflect-metadata';
 import { ITestVisitor, TestFile, TestFolder, TestFunction, TestStatus, TestSuite } from '../types';
 
 @injectable()

src/client/unittests/nosetest/main.ts

@@ -1,5 +1,4 @@
 import { inject, injectable } from 'inversify';
-import 'reflect-metadata';
 import { Uri } from 'vscode';
 import { PythonSettings } from '../../common/configSettings';
 import { Product } from '../../common/types';

src/client/unittests/nosetest/services/discoveryService.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable, named } from 'inversify';
-import 'reflect-metadata';
 import { CancellationTokenSource } from 'vscode';
 import { IServiceContainer } from '../../../ioc/types';
 import { NOSETEST_PROVIDER } from '../../common/constants';

src/client/unittests/nosetest/services/parserService.ts

@@ -4,7 +4,6 @@
 import { inject, injectable } from 'inversify';
 import * as os from 'os';
 import * as path from 'path';
-import 'reflect-metadata';
 import { convertFileToPackage, extractBetweenDelimiters } from '../../common/testUtils';
 import { ITestsHelper, ITestsParser, ParserOptions, TestDiscoveryOptions, TestFile, TestFunction, Tests, TestStatus, TestSuite } from '../../common/types';
 

src/client/unittests/pytest/services/discoveryService.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { inject, injectable, named } from 'inversify';
-import 'reflect-metadata';
 import { CancellationTokenSource } from 'vscode';
 import { IServiceContainer } from '../../../ioc/types';
 import { PYTEST_PROVIDER, UNITTEST_PROVIDER } from '../../common/constants';

src/client/unittests/pytest/services/parserService.ts

@@ -4,7 +4,6 @@
 import { inject, injectable } from 'inversify';
 import * as os from 'os';
 import * as path from 'path';
-import 'reflect-metadata';
 import { convertFileToPackage, extractBetweenDelimiters } from '../../common/testUtils';
 import { ITestsHelper, ITestsParser, ParserOptions, TestDiscoveryOptions, TestFile, TestFunction, Tests, TestStatus, TestSuite } from '../../common/types';