Add functional tests for test adapter (#21803)

closes #21767
microsoft · Aug 14, 2023 · 64478bf · 64478bf
1 parent 84df45c
commit 64478bf
Show file tree

Hide file tree

Showing 6 changed files with 458 additions and 7 deletions.
diff --git a/src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts b/src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts
@@ -98,6 +98,7 @@ export class PytestTestDiscoveryAdapter implements ITestDiscoveryAdapter {
             deferredExec.resolve({ stdout: '', stderr: '' });
             deferred.resolve();
         });
+
         await deferredExec.promise;
     }
 }
diff --git a/src/client/testing/testController/pytest/pytestExecutionAdapter.ts b/src/client/testing/testController/pytest/pytestExecutionAdapter.ts
@@ -175,7 +175,7 @@ export class PytestTestExecutionAdapter implements ITestExecutionAdapter {
                     this.outputChannel?.append(data);
                 });
 
-                result?.proc?.on('close', () => {
+                result?.proc?.on('exit', () => {
                     deferredExec.resolve({ stdout: '', stderr: '' });
                     deferred.resolve();
                     disposeDataReceiver?.(this.testServer);

diff --git a/src/test/linters/lint.functional.test.ts b/src/test/linters/lint.functional.test.ts
@@ -4,7 +4,6 @@
 'use strict';
 
 import * as assert from 'assert';
-import * as childProcess from 'child_process';
 import * as fs from 'fs-extra';
 import * as os from 'os';
 import * as path from 'path';
@@ -780,11 +779,6 @@ suite('Linting Functional Tests', () => {
     teardown(() => {
         sinon.restore();
     });
-
-    const pythonPath = childProcess.execSync(`"${PYTHON_PATH}" -c "import sys;print(sys.executable)"`);
-
-    console.log(`Testing linter with python ${pythonPath}`);
-
     // These are integration tests that mock out everything except
     // the filesystem and process execution.