Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons to match new style #1261

Merged
merged 5 commits into from
Jul 17, 2019
Merged

Update icons to match new style #1261

merged 5 commits into from
Jul 17, 2019

Conversation

miguelsolorio
Copy link

See microsoft/vscode#8017 (comment), this updates all of the icons to match the new style. Also tried fixing some alignment/spacing issues with the new sizes:

image

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Jul 12, 2019

Thanks @misolori! There’s only one icon that looks a bit weird to me, the diff.svg that’s shown when a reviewer has requested changes:
Screen Shot 2019-07-12 at 12 02 17 PM
Is there anything that looks more like the original? Now that I know the filename is diff it makes sense to me, but when I first saw it in this context I was confused about what it was. Maybe it would be better to remove that icon from the extension and just use the ‘x’ instead?

Do we have a version of https://octicons.github.com/icon/request-changes/?

@miguelsolorio
Copy link
Author

@RMacfarlane thanks, let me see if I can find an alternative that matches that or create a similar one.

@miguelsolorio
Copy link
Author

I've update the requested changes icon to match https://octicons.github.com/icon/request-changes/

image

Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RMacfarlane RMacfarlane merged commit a3d93ef into master Jul 17, 2019
@RMacfarlane RMacfarlane deleted the misolori/icons branch January 22, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants