Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit PR title, does not (auto) update title of PR in treeview (PR in list on left side) #2299

Closed
ranavale opened this issue Nov 25, 2020 · 4 comments · Fixed by #3119
Closed

Edit PR title, does not (auto) update title of PR in treeview (PR in list on left side) #2299

ranavale opened this issue Nov 25, 2020 · 4 comments · Fixed by #3119
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2021

Comments

@ranavale
Copy link

  • Extension version:v0.21.2
  • VSCode Version:1.51
  • OS:Windows

Steps to Reproduce:

  1. Open Pull request
  2. Go to PR description.
  3. Edit title of pr.
  4. Wait for sync? nothing happens
  5. Refresh PR: still the PR in list has old title.
  6. Solution: Refresh the PR list from its treeview control. (I would expect it to happen when title is edited automatically)
@ranavale ranavale changed the title Edit PR title, does not update title of PR in treeview (PR in list on left side) Edit PR title, does not (auto) update title of PR in treeview (PR in list on left side) Nov 25, 2020
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Dec 1, 2020
@RMacfarlane RMacfarlane added the good first issue Good for newcomers label Dec 18, 2020
@sumitani
Copy link

Can I work on it? @RMacfarlane

@sumitani sumitani mentioned this issue Jul 15, 2021
Closed
@alexr00 alexr00 removed the good first issue Good for newcomers label Jul 16, 2021
@alexr00
Copy link
Member

alexr00 commented Jul 16, 2021

Turns out this isn't a good first issue since there is some refactoring work that will need to be done to expose a nice way to refresh the list.

@alexr00 alexr00 added this to the November 2021 milestone Nov 19, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 19, 2021

Found a not bad way to do this, and also ensured the title is updated in other places.

alexr00 added a commit that referenced this issue Nov 19, 2021
@alexr00
Edit PR title, does not (auto) update title of PR in treeview (PR in …
758cbe5 
…list on left side)

Fixes #2299
@alexr00 alexr00 mentioned this issue Nov 19, 2021
Merged
alexr00 added a commit that referenced this issue Nov 19, 2021
@alexr00
Edit PR title, does not (auto) update title of PR in treeview (PR in …
b27aafe 
…list on left side) (#3119)

Fixes #2299
@tanhakabir tanhakabir added the verified Verification succeeded label Dec 1, 2021
@tanhakabir
Copy link

There's a little bit of lag but verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2021
5 participants
@sumitani @RMacfarlane @tanhakabir @alexr00 @ranavale