Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New commits on PR appears misaligned #1353

Closed
JeffreyCA opened this issue Oct 3, 2019 · 2 comments · Fixed by #1357
Closed

New commits on PR appears misaligned #1353

JeffreyCA opened this issue Oct 3, 2019 · 2 comments · Fixed by #1357

Comments

@JeffreyCA
Copy link
Member

JeffreyCA commented Oct 3, 2019

Back from a long hiatus!

  • Extension version: 0.12.0
  • VSCode Version: 1.39.0
  • OS: macOS 10.14.6

Steps to Reproduce:

  1. Navigate to PR where there is an added commit

Issues:

  • Commit hash is misaligned
  • Username overflows to two lines

Screen Shot 2019-10-02 at 10 56 02 PM

@RMacfarlane
Copy link
Contributor

Welcome back @JeffreyCA!

The rendering of the "..." button on GitHub seems a bit strange to me
Screen Shot 2019-10-03 at 9 49 45 AM
But I think something like this would be useful, since the commit message could potentially span even more than two lines. My expectation when I clicked to expand was that it would render the whole text as an unbroken block and move the "..." button the end

@RMacfarlane
Copy link
Contributor

Looking back through old issues, there's #302 already tracking the "..." for toggling the whole commit message. So let's use this issue to specifically track the alignment issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants