Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the workspace/foldingRange/refresh method #1309

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Add the workspace/foldingRange/refresh method #1309

merged 4 commits into from
Sep 18, 2023

Conversation

c-claeys
Copy link
Contributor

Relating to #1306

server.ts has onFoldingRanges already which I've left alone for backwards compatibility but this PR also adds languages.foldingRange.on which should be identical.

@dbaeumer
Copy link
Member

@c-claeys very nice work. Thanks a lot. One minor thing. Can you mark the @SInCE 3.18 as proposed as well. This will allow me to ship it with 3.17.4 as a preview.

And are you working on a PR for the spec as well?

@c-claeys c-claeys force-pushed the folding-range-refresh branch from c4439ef to 4aefc80 Compare September 14, 2023 14:07
@c-claeys
Copy link
Contributor Author

Added the proposed tag.

And are you working on a PR for the spec as well?

Yeah it should be out for review shortly. I figured I'd ensure this goes smoothly first.

@dbaeumer dbaeumer enabled auto-merge (squash) September 18, 2023 09:21
@dbaeumer dbaeumer merged commit 4e057d5 into microsoft:main Sep 18, 2023
@dbaeumer dbaeumer modified the milestones: September 2023, Next Sep 18, 2023
@c-claeys c-claeys deleted the folding-range-refresh branch September 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

@aeschli aeschli aeschli approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
September 2023
Projects
None yet
Milestone
3.17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@c-claeys @dbaeumer @aeschli @alexr00