Add formatMultipleRanges to DocumentRangeFormattingFeature

[c-claeys]

Add multirange formatting support via new request textDocument/rangesFormatting

This does nothing besides break npm run compile ATM, but I'm looking for advice. Am I missing some hook to correctly include the proposed API? I received the proposed .d.ts via npx vscode-dts dev, but compile doesn't seem to pick it up AFAICT.

[dbaeumer]

Couple of comments:

• the client/tsconfig.json file is only a composite project file which shouldn't reference any files.

To get it work I would do the following:

• create a typings folder next to src
• move the d.ts into there
• in the formatting.ts file reference the typings file using /// <reference path="../../typings/...." />

The reason here is that we need to ship the typings file as well since otherwise other users can't compile against the library.

[c-claeys]

Sounds good. I was just looking at past discussions. Initially we were thinking of putting additional ranges in the formatting options but VSCode's API sync resulted in parallel functions exposed on that API. Any opinion over whether the formatting options should be modified to include ranges, if a new formatting method (textDocument/rangesFormatting) should be added, or something else?

[dbaeumer]

I would got with a new request textDocument/rangesFormatting. I am not a bug fan of having this encoded in the options.

[dbaeumer]

Since we add a capability to an existing client feature we should add a corresponding capability to the formatting client capabilities. A good name would be multipleRangesSupport: boolean or rangesSupport: boolean.

[dbaeumer]

We need a @SInCE tag here and a @proposed tag

[c-claeys]

Done.

[dbaeumer]

to make things consitent with other name and the client capability I would name it multipleRangesSupport or rangesSupport

[c-claeys]

Done.

[dbaeumer]

Otherwise (as always) great PR.

[c-claeys]

Otherwise (as always) great PR.

Cheers! Thanks for the reviews

[dbaeumer]

PR looks good. @c-claeys are you providing a spec change as well?

[c-claeys]

Sure, happy to follow up with a spec change PR