Fix tabbing through all levels for completions in a path #8792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| // If inside a string and ending with '/', then add a command to force a suggestion right after | ||
| result = result.map((r) => { | ||
| if (r.itemText.endsWith('/')) { |
There was a problem hiding this comment.
What happens if a path ends with \, or is this specific to just /
There was a problem hiding this comment.
Jupyter always returns paths with '/' on them.
Codecov Report
@@ Coverage Diff @@
## main #8792 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 382 382
Lines 24690 24694 +4
Branches 3804 3805 +1
=====================================
+ Hits 17655 17658 +3
- Misses 5506 5512 +6
+ Partials 1529 1524 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7816
Thanks @misolori. I used the html extension and figured out what it was returning differently. Its completion items include a command to run when they are completed.