Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install IPyKernel into venv without using Python ext #8456

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Dec 4, 2021

For #1253
For #421

@DonJayamanne DonJayamanne requested a review from a team as a code owner December 4, 2021 00:03
/**
* Class used to install IPyKernel into global enviroments if Python extension fails to install it for what ever reason.
* Class used to install IPyKernel into global environments if Python extension fails to install it for what ever reason.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you notice, I've fixed a typo (installed spell checker, for some reason this was uninstalled on my mac)

@codecov-commenter
Copy link

Codecov Report

Merging #8456 (5dbc907) into main (8f6665e) will decrease coverage by 0%.
The diff coverage is 11%.

@@          Coverage Diff          @@
##            main   #8456   +/-   ##
=====================================
- Coverage     71%     71%   -1%     
=====================================
  Files        376     376           
  Lines      23814   23816    +2     
  Branches    3669    3669           
=====================================
- Hits       17124   17116    -8     
- Misses      5200    5210   +10     
  Partials    1490    1490           
Impacted Files Coverage Δ
src/client/common/installer/backupPipInstaller.ts 23% <6%> (-2%) ⬇️
src/client/common/installer/productInstaller.ts 52% <50%> (+1%) ⬆️
...ent/datascience/jupyter/pythonVariableRequester.ts 68% <0%> (-6%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 77% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 77% <0%> (-1%) ⬇️
src/client/datascience/baseJupyterSession.ts 76% <0%> (+<1%) ⬆️
...ence/editor-integration/cellHashProviderFactory.ts 100% <0%> (+2%) ⬆️

@DonJayamanne DonJayamanne merged commit c66a67c into main Dec 4, 2021
@DonJayamanne DonJayamanne deleted the installVirtualEnvIPyKernel branch December 4, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants