-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling when kernel crashes due to overridden built in modules #8237
Conversation
@@ -11,9 +11,6 @@ | |||
# See comment at the point of our use of Popen | |||
from subprocess import Popen, PIPE # nosec | |||
|
|||
from ipython_genutils.encoding import getdefaultencoding | |||
from ipython_genutils.py3compat import cast_bytes_py2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer required, was only required for python 2.7
Also ipython_genutils is no longer shipping in conda
Codecov Report
@@ Coverage Diff @@
## main #8237 +/- ##
======================================
Coverage 71% 71%
======================================
Files 368 369 +1
Lines 22613 22751 +138
Branches 3423 3460 +37
======================================
+ Hits 16229 16373 +144
+ Misses 4986 4952 -34
- Partials 1398 1426 +28
|
4e9a0ea
to
fc6808b
Compare
Moved from
Damn it, sorry, will change.
Oops. |
Fixes #8195
Fixes #5896
Fixes #6791