Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stop button #7138

Merged
merged 1 commit into from
Aug 14, 2021
Merged

remove stop button #7138

merged 1 commit into from
Aug 14, 2021

Conversation

DavidKutu
Copy link

For #6904 and #6860

To stop, users can click the stop cell button on the left.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner August 14, 2021 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #7138 (c49bdec) into main (b7d582c) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #7138   +/-   ##
=====================================
  Coverage     64%     64%           
=====================================
  Files        362     362           
  Lines      22902   22897    -5     
  Branches    3435    3434    -1     
=====================================
+ Hits       14850   14855    +5     
+ Misses      6737    6729    -8     
+ Partials    1315    1313    -2     
Impacted Files Coverage Δ
src/client/datascience/constants.ts 99% <ø> (-1%) ⬇️
src/client/debugger/jupyter/debuggingManager.ts 28% <ø> (+<1%) ⬆️
...lient/datascience/variablesView/notebookWatcher.ts 83% <0%> (-3%) ⬇️
src/client/datascience/baseJupyterSession.ts 63% <0%> (-1%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 45% <0%> (+<1%) ⬆️
...t/datascience/notebook/vscodeNotebookController.ts 79% <0%> (+1%) ⬆️
.../datascience/notebook/notebookControllerManager.ts 86% <0%> (+1%) ⬆️
src/client/common/cancellation.ts 76% <0%> (+4%) ⬆️

@DavidKutu DavidKutu merged commit 28644bc into main Aug 14, 2021
@DavidKutu DavidKutu deleted the david/removeExtraStop branch August 14, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants