KernelPush #5565
KernelPush #5565
Conversation
|
@DonJayamanne I've had the branch up. But figure that it might be easier to discuss issues with this actually up as a draft PR, so I'm putting this up here so we can discuss changes easier. |
|
Remaining work tracker:
|
| @@ -107,6 +102,9 @@ export class VSCodeNotebook implements IVSCodeNotebook { | |||
| ): Disposable { | |||
| return notebook.registerNotebookKernelProvider(selector, provider); | |||
| } | |||
| public createNotebookController(id: string, selector: NotebookSelector, label: string, handler?: NotebookExecutionHandler, preloads?: NotebookKernelPreload[]): NotebookController { | |||
There was a problem hiding this comment.
How about making this static, we don't really need an instance method on this (this way we know that there's no state information or the like).
E.g. my immediate assumption was there's something that ties this controller to the instance of this class
| } | ||
|
|
||
| private onDidChangeExtensions() { | ||
| // IANHU: Need to invalidate kernels here? |
There was a problem hiding this comment.
Curious what were we planning on putting here?
Is this for if user installs Python extenison?
There was a problem hiding this comment.
Yeah, I believe that's what it was for before. Back in the old pull provider we would signal onDidChangeKernels when extensions changed. Now we need to instead dispose and regenerate NotebookControllers. Just saving this with a todo: as I think we can do it after most everything else is working (i.e. not a super important scenario, you can just close and open the file to get a new list).
|
Issues to discuss with VS Code:
|
|
For anyone on the team looking. Don and I have been working on this today and I wanted to put it up for others to take a peek if they want. But we're going to have to fix up more of this tomorrow. Widgets for sure will not be ready, as well as a number of other issues. I'm going to keep working on this tonight and see where we can get. At a minimum we'll push an extension in the morning to make sure that the extension doesn't just straight up crash. KERNELPUSH marks the known spots in code that still need attention |
For #
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).