Skip to content
This repository has been archived by the owner on Apr 23, 2022. It is now read-only.

pnp codegen some suggestions #913

Open
dooriya opened this issue Feb 6, 2020 · 0 comments
Open

pnp codegen some suggestions #913

dooriya opened this issue Feb 6, 2020 · 0 comments
Assignees
@dooriya
Labels
CodeGen Enhancement

Comments

@dooriya
Copy link
Member

dooriya commented Feb 6, 2020

[Name]_Interface_Telemetry_SendAll() is poorly written
A chance for buffer overrun and stack corruption
These should not be on the stack as MAX_MESSAGE_SIZE is 512 and these should be
implemented with snprintf instead of sprintf.

File structure
The implementation files are on root but the interfaces are inside utilities. this is confusing.

Note: This issue is redirected from: Azure/azure-iot-sdk-c#1412
@dooriya dooriya self-assigned this Feb 6, 2020
@dooriya dooriya added the CodeGen label Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dooriya dooriya

Labels
CodeGen Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dooriya