Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnp codegen some suggestions #1412

Closed
uriel-kluk opened this issue Jan 29, 2020 · 3 comments
Closed

pnp codegen some suggestions #1412

uriel-kluk opened this issue Jan 29, 2020 · 3 comments
Labels

Comments

@uriel-kluk
Copy link

uriel-kluk commented Jan 29, 2020

[Name]_Interface_Telemetry_SendAll() is poorly written

A chance for buffer overrun and stack corruption
These should not be on the stack as MAX_MESSAGE_SIZE is 512 and these should be
implemented with snprintf instead of sprintf.

File structure

The implementation files are on root but the interfaces are inside utilities. this is confusing

@JerryYangKai
Copy link

JerryYangKai commented Feb 24, 2020

@uriel-kluk Thanks for your feedback. I will fix these issue in our further released

@ericwolz ericwolz added the pnp label Mar 6, 2020
@jspaith
Copy link
Contributor

jspaith commented Jun 9, 2020

Thanks for feedback @uriel-kluk . Like other one I recently closed, I'm closing this as well since it's not our repo directly that can fix and @JerryYangKai is tracking.

@jspaith jspaith closed this as completed Jun 9, 2020
@az-iot-builder-01
Copy link
Collaborator

@uriel-kluk, @JerryYangKai, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants