Add debugTestAtCursor command #2059
Conversation
|
|
There was a problem hiding this comment.
Thanks for the PR @Ashiroq!
There is a lot of pre-processing being done in https://github.com/Microsoft/vscode-go/blob/0.6.93/src/goRunTestCodelens.ts#L89 that is missing here.
I would suggest to refactor that code so that it can be used here.
Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean
Happy Coding!
|
@Ashiroq I have some fixes at #2281 , can you give me permission to push to your branch ? @jhendrixMSFT , @ramya-rao-a ( getting permission denied when trying to push to the branch so assuming the permission was disabled ) |
|
I sent you an invitation to collaborators. |
ac92583 to
d5dfc5c
Compare
|
@Ashiroq I managed to update the branch. @ramya-rao-a i tested the the suite scenario for both the codelens and the command and they work fine. |
d5dfc5c to
d44a6c8
Compare
d44a6c8 to
2813e4a
Compare
| }).then(null, err => { | ||
| console.error(err); | ||
| }); | ||
| const isMod = await isModSupported(editor.document.uri); |
There was a problem hiding this comment.
@ramya-rao-a here I have a question. previously the testConfig was saved to the global lastTestConfig without the isMod property. was that intentional or by accident ?
There was a problem hiding this comment.
i presume it was intended to be saved since the call to running previous test used it. if so then its fine since i just made it immutable but still is saved ( otherwise it should be cloned instea of just assigned )
|
@jhendrixMSFT , @ramya-rao-a the metalinter test seems to be failing although from looking at it doesn't seem related to anything i've changed. Any idea why ? |
|
@vladbarosan There was a new release of the metalinter v3.0.0 which has breaking changes. How about you update travis to pin to v2.0.12 until we have time to react to these changes? |
6404145 to
80ca933
Compare
|
@jhendrixMSFT doesn't seem to have helped :( |
80ca933 to
944f937
Compare
|
@jhendrixMSFT ok figured it out, it seems not only that the new version broke us but also the new install script version ( probably because it seems to be removing some checkers ). As all our CI is blocked as of now, I locked to the previous script version for now and tracking the issue here #2292 |
There was a problem hiding this comment.
As part of #2193, we now show test coverage even if test fails. So, I pushed a commit accordingly.
This was awesome work, thanks @vladbarosan!
Closes #1088
Adds command for debugging test at the current position of cursor similar to "debug test" codeLens.
By default, the command is hidden in the context menu, if codeLens is enabled just like with testAtCursor command.
Let me know if I can improve this :)