Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

The "." (dot) inside comment open the suggestion/completion list #1659

Closed
uudashr opened this issue May 5, 2018 · 2 comments
Closed

The "." (dot) inside comment open the suggestion/completion list #1659

uudashr opened this issue May 5, 2018 · 2 comments
Labels
help wanted

Comments

@uudashr
Copy link
Contributor

uudashr commented May 5, 2018

Steps to Reproduce:

  1. Create comment on the right side of the code
  2. Type "." (dot) and the completion list will opened

screen shot 2018-05-06 at 01 40 54

Expect: The completion should not appear since it's inside the comment
@ramya-rao-a
Copy link
Contributor

Nice catch.
PRs are welcome.
The fix would go in the place where we have a check to avoid calling suggestions when the complete line is a comment. https://github.com/Microsoft/vscode-go/blob/0.6.79/src/goSuggest.ts#L55

doxxx added a commit to doxxx/vscode-go that referenced this issue May 12, 2018
@doxxx
Fix prevention of completion popup in line comments. (fixes microsoft…
48f8db0 
…#1659)
@doxxx doxxx mentioned this issue May 12, 2018
Merged
ramya-rao-a pushed a commit that referenced this issue May 13, 2018
@doxxx @ramya-rao-a
Fix prevention of completion popup in line comments. (fixes #1659) (#…
0673847 
…1671)

* Fix prevention of completion popup in line comments. (fixes #1659)

* Use indexOf instead of regex.

* Recognize line comments starting in column 0.
@ramya-rao-a
Copy link
Contributor

This bug fix is now out in the latest update to the Go extension (0.6.80)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uudashr @ramya-rao-a