-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pnpm as a package manager #339
Merged
Merged
+442
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @aeschli, Friendly ping about this PR. Is anything else needed from me to move forward with it? |
aeschli
approved these changes
Jul 6, 2022
dbaeumer
approved these changes
Jul 6, 2022
Thanks @nhedger ! |
I think we should revert this. Because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for pnpm as a package manager.
Closes #324
Changes
Based on the existing tests, I've created additional tests to validate support for
pnpm
with all relevant templates.While implementing the
sample notebook renderer with pnpm
test, I had to update theext-notebook-renderer
template because the package manager was hardcoded tonpm
. It will now be replaced by the selected package manager, as in other templates.Modifying the
ext-notebook-renderer
template initially broke thesample notebook renderer
test because the prompt definedyarn
while it expected to findnpm
. I fixed that by replacing the prompt withnpm
.Checklist