-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev container content #5906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left minor comments!
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Thanks so much for the fast review, @samruddhikhandale! Merged all your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Missed -bullseye
in two other places.
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Thanks! Just merged those changes in. |
In the CLI section, we still tell people to add their features again to the secondary devcontainer.json. That's no longer required in the image pre-build situation so...
|
@Chuxel thanks so much for the detailed review! I believe I've addressed and replied to your comments above. |
One thing I'm not sure we have a good link to anywhere is image metadata. We allude to it in the pre-builds section but we're a bit more specific in the containers.dev docs. https://containers.dev/implementors/reference/#labels EDIT: In fact, I noticed a couple bad links, and refreshed the Dev Container spec section on this as well: devcontainers/devcontainers.github.io#122 |
Thanks @Chuxel! I expanded the info on metadata in the pre-build section (like what you added in the linked containers.dev PR), and I added links to this content from the Notes I had added on metadata throughout other docs. |
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
@gregvanl This is ready for your review and merge whenever you're ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 2 nits.
Based on team discussions and customer feedback, we've been assembling a list of docs to update: #5737.
Summary of changes: