Incorrect "Request forwarding" conclusion about diagnostics #5778
Labels
Comments
|
I commented on microsoft/vscode#159911 So we are only half way there. LSP now has a protocol for diagnostic pull, but our VS Code API not yet. I update the docs. |
aeschli
added a commit
that referenced
this issue
Nov 11, 2022
|
Closing as fixed in vscode-docs vnext branch. This will be published live when the next release goes out beginning of December. |
gregvanl
pushed a commit
that referenced
this issue
Dec 6, 2022
* Add 1.73 release notes placeholder * JSONC documentation seems incomplete, doesn't mention trailing commas. Fixes #5728 * VS Code for the Web supports Language Packs! * Input latency notes * fix #164628 * Mention that trailing commas in JSONC are discouraged * Update 1.73 vscode.d.ts commit ID * news * Add Settings editor release notes * Update workspace trust settings picture * Adding placeholder sections * Add placeholder * added notes for include/exclude search result commands * Update 1.73 Windows keybindings * Dev Containers release notes * update * Issue trackers * adding release notes * Release notes * Add Python release notes * Update v1_73.md * VS Code for the Web branch protection release notes * Add command center content * Add rounded corners entry * Update release notes * Add quick pick styles entry * Add list codicons update entry * Add list icon video * Adding proposed api sections * Add ts preview section * Add dev container template info * Undo non-lfs image * Reupload with lfs * Adding md link update * localization for the web * add accessibility updates * Add jupyter release note TODOs * Add startDebugging release note * Notable fix * typos and section reordering * Jupyter debug release notes * Add Markdown link occurrence highlighting section * Update 1.73 settings * release notes edits * Add section on md insert links * Add api sections * Add dup md section * Update thank you. * edit * Make doc links absolute * Small edits * add logging improvements * add settings profiles improvements * Add screenshot * chore: add windows11 context menu notes * merge editor release notes * release notes: list.collapseAllToFocus * Updates merge editor release notes. * More merge editor release notes * Merge editor wording improvements * Add community contributions for vscode-dev-chrome-launcher * ImageOptim * Update channel name * Fix setting value for Pylance auto imports * Tune image alt text * Update 1.73 vscode.d.ts commit ID * Add 1.73 highlights and social image * Remove Jupyter release notes from deferred release * Remove the sections on the Jupyter extension * Update 1.73 social image to remove Jupyter * Shrink images and optimize .gifs * Update theme color. * release notes edits * Edit theme-color.md * Update DateApproved * Add 1.74 release notes placeholder * Add quick pick title and placeholder guidance * Incorrect "Request forwarding" conclusion about diagnostics. Fixes #5778 * Update 1.74 settings * Update 1.74 vscode.d.ts commit ID * Update 1.74 Windows keybindings * 1.74 settings updates * mangle news * Git - unsafe repositories (#5818) * Unsafe repository question * Tweak the message * Mention accessibility tag * Add release notes for indicators a11y and WCO * Clarify WCO re-enablement * add accessibility, task, terminal updates * Update release notes * Dev Container notes * Thank yous * Add release notes * Fix typo * Implicit activation events * Polish implicit activation events section * add release notes * make link work * Implicit activation events documentation updates * Edits and reordering * Add note * Typo * auth bundle improvements * call out l10n * VS Code for the Web release notes * SCM action button * finalise log api * Sharing profiles * document Install Extension from Location command * Adding TS sections * Adding sections * update kernel picker change * Update jupyter extension changelog * Jupyter release notes * Notebook audio cues * Small edits and formatting * killOnServerStop release notes * Exception breakpoints view release notes * add acknowledgements for 1.74 * Update release notes * First cut for Python on the Web * update color referemce * platform specific extension docs clarifications regarding microsoft/vscode-vsce#785 * release notes: extension signing and verification fyi @sandy081 * Release notes * Adds merge editor release notes * Mentions command to partially accept inline suggestions. * More Python documentation * Sell the WCO re-enablement better * Minor word tweaks * Elaborate on improved Settings editor a11y * Add images to Git LFS * Small edits, reordering, and mention sandbox blog * 1.74 highlights and social image * Small updates * Alt text tuning * Comments and GHPRI release notes * update acknowledgements * release notes: @vscode/vsce * 🎤 Introduce `search` file location method Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * Small edits to recent updates * Edit pass on Python for the Web * Add tunnels topic to sitemap * Prep for Insiders snapshot, add images to Git LFS Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Johannes <johannes.rieken@gmail.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: andreamah <andrea_mah22@hotmail.com> Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Co-authored-by: Christof Marti <chrmarti@microsoft.com> Co-authored-by: SteVen Batten <sbatten@microsoft.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Courtney Webster <clw99@swbell.net> Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com> Co-authored-by: bamurtaugh <brmurtau@microsoft.com> Co-authored-by: Tyler Leonhardt <me@tylerleonhardt.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Peng Lyu <penlv@microsoft.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Joao Moreno <joao.moreno@microsoft.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: rebornix <penn.lv@gmail.com> Co-authored-by: Dirk Bäumer <dirkb@microsoft.com> Co-authored-by: isidor <inikolic@microsoft.com> Co-authored-by: Alex Dima <alexdima@microsoft.com> Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
gregvanl
pushed a commit
that referenced
this issue
Dec 7, 2022
* Add 1.73 release notes placeholder * Initial tunnel updates * More info and updates * Typo * Update desktop * Wording and flow * JSONC documentation seems incomplete, doesn't mention trailing commas. Fixes #5728 * VS Code for the Web supports Language Packs! * add tunnel to ext host configurations table * Input latency notes * fix #164628 * Mention that trailing commas in JSONC are discouraged * Update 1.73 vscode.d.ts commit ID * news * Add Settings editor release notes * Update workspace trust settings picture * Adding placeholder sections * Add placeholder * added notes for include/exclude search result commands * Update 1.73 Windows keybindings * Dev Containers release notes * update * Issue trackers * adding release notes * Release notes * Add Python release notes * Update v1_73.md * VS Code for the Web branch protection release notes * Add command center content * Add rounded corners entry * Update release notes * Add quick pick styles entry * Add list codicons update entry * Add list icon video * Adding proposed api sections * Add ts preview section * Add dev container template info * Undo non-lfs image * Reupload with lfs * Adding md link update * localization for the web * add accessibility updates * Add jupyter release note TODOs * Add startDebugging release note * Notable fix * typos and section reordering * Jupyter debug release notes * Add Markdown link occurrence highlighting section * Update 1.73 settings * release notes edits * Add section on md insert links * Add api sections * Add dup md section * Update thank you. * edit * Make doc links absolute * Small edits * add logging improvements * add settings profiles improvements * Add screenshot * chore: add windows11 context menu notes * merge editor release notes * release notes: list.collapseAllToFocus * Updates merge editor release notes. * More merge editor release notes * Merge editor wording improvements * Add community contributions for vscode-dev-chrome-launcher * ImageOptim * Update channel name * Fix setting value for Pylance auto imports * Tune image alt text * Update 1.73 vscode.d.ts commit ID * Add 1.73 highlights and social image * Remove Jupyter release notes from deferred release * Remove the sections on the Jupyter extension * Update 1.73 social image to remove Jupyter * Shrink images and optimize .gifs * Update theme color. * release notes edits * Edit theme-color.md * Update DateApproved * Add 1.74 release notes placeholder * Add quick pick title and placeholder guidance * Incorrect "Request forwarding" conclusion about diagnostics. Fixes #5778 * Edit pass * Wording polish * Update 1.74 settings * Edit pass * Edit pass * Polish and feedback * Wording * Wording * Add blog * Formatting * Update 1.74 vscode.d.ts commit ID * Update 1.74 Windows keybindings * 1.74 settings updates * A few initial edits and formatting * mangle news * Git - unsafe repositories (#5818) * Unsafe repository question * Tweak the message * Mention accessibility tag * Add release notes for indicators a11y and WCO * Clarify WCO re-enablement * add accessibility, task, terminal updates * Update release notes * Dev Container notes * Thank yous * Add release notes * Fix typo * Implicit activation events * Polish implicit activation events section * add release notes * make link work * Implicit activation events documentation updates * Edits and reordering * Add note * Update remote-even-better.md * Typo * auth bundle improvements * call out l10n * Update command * VS Code for the Web release notes * Add statement * SCM action button * finalise log api * Sharing profiles * document Install Extension from Location command * Adding TS sections * Adding sections * update kernel picker change * Update jupyter extension changelog * Jupyter release notes * Notebook audio cues * Small edits and formatting * killOnServerStop release notes * Exception breakpoints view release notes * add acknowledgements for 1.74 * Update release notes * First cut for Python on the Web * update color referemce * platform specific extension docs clarifications regarding microsoft/vscode-vsce#785 * release notes: extension signing and verification fyi @sandy081 * Release notes * Adds merge editor release notes * Mentions command to partially accept inline suggestions. * More Python documentation * Sell the WCO re-enablement better * Minor word tweaks * Elaborate on improved Settings editor a11y * Add images to Git LFS * Small edits, reordering, and mention sandbox blog * 1.74 highlights and social image * Small updates * Alt text tuning * Comments and GHPRI release notes * update acknowledgements * release notes: @vscode/vsce * 🎤 Introduce `search` file location method Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * Small edits to recent updates * Edit pass on Python for the Web * Add tunnels topic to sitemap * Prep for Insiders snapshot, add images to Git LFS * Add new content back to TOC, tune images * first pass at profiling docs (#5833) * Edit pass and Audio Cues dropdown image * Edit pass on new JS profiling topic * Shrink .gifs * Edit pass on blog post * Edit pass on tunnels topic * Refer to insider version * Update DateApproved Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> Co-authored-by: bamurtaugh <brmurtau@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Johannes <johannes.rieken@gmail.com> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: andreamah <andrea_mah22@hotmail.com> Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com> Co-authored-by: Christof Marti <chrmarti@microsoft.com> Co-authored-by: SteVen Batten <sbatten@microsoft.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Courtney Webster <clw99@swbell.net> Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com> Co-authored-by: Tyler Leonhardt <me@tylerleonhardt.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Peng Lyu <penlv@microsoft.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Joao Moreno <joao.moreno@microsoft.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: rebornix <penn.lv@gmail.com> Co-authored-by: Dirk Bäumer <dirkb@microsoft.com> Co-authored-by: isidor <inikolic@microsoft.com> Co-authored-by: Alex Dima <alexdima@microsoft.com> Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the docs, the following is stated about cons of "Request forwarding" (https://code.visualstudio.com/api/language-extensions/embedded-languages#conclusion):
The line "LSP in 3.17 will provide a diagnostic pull model that will make this possible." has been added because of the following issue: microsoft/vscode-extension-samples#430 (comment) in commit e885ed2
However, now that LSP 3.17 is released and is implemented in some language servers (HTML/JSON/CSS) you would think it's possible to use "diagnostic pull model" in vscode, which is not the case. After a lot of digging I've asked in the vscode repository if this could be implemented. The response is that it won't be implemented: microsoft/vscode#159911 (comment)
So yes, in LSP 3.17 it's possible to use the new "diagnostic pull model" but you can't use the API's in vscode to actually forward the requests and make use of this new diagnostics API.
Shouldn't the mention about LSP 3.17 be removed? Since it gives false hope 🥲
The text was updated successfully, but these errors were encountered: