Use ENV key=value in Dockerfile templates #2344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In our docs.docker.com we've removed the examples that used the old syntax
ENV key value
and replaced it with the betterENV key=value
syntax (related docker/docs#11414).The old style had its problems when using multiple environment variables
ENV ONE TWO= THREE=world
Just yesterday I used the Docker extension in preparation for a Docker beginners video course and saw that the Docker extension uses the old style.
This PR changes the templates to the new style and helps users to use the good practice.