Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dapr CLI/runtime version validation #183

Merged
merged 8 commits into from
Jul 12, 2021

Conversation

philliphoff
Copy link
Member

The current extension attempts to validate that Dapr has been installed and initialized. However, that logic is fairly old (e.g. looking for the Dapr Docker container instead of using the now available runtime version number) and did not work for locally-built versions of the Dapr CLI (which uses the semver-incompatible 'edge' string).

The new logic offers more comprehensive validation (e.g. minimum version checks as well as broader enforcement) and refreshes the messaging for when invalid versions are found. Much of the logic is borrowed from vscode-tye.

Shown when no (compatible) version of the CLI is found:

Screenshot 2021-06-16 at 15 37 23

Shown when no (compatible) version of the runtime is found:

Screenshot 2021-06-16 at 15 25 37

Shown when Dapr is installed and initialized but no applications are running:

Screenshot 2021-06-16 at 15 26 49

Shown when attempting to run a dapr or daprd task when there is an incompatibility:

Screenshot 2021-06-16 at 15 26 11

Resolves: #171

@alexdresko
Copy link

@philliphoff Any chance we can fix these conflicts and smash the merge button?

Copy link

@pratiksanglikar pratiksanglikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one nitpicking comment for updating a variable name.

@philliphoff philliphoff merged commit 6494b97 into main Jul 12, 2021
@philliphoff philliphoff deleted the philliphoff-version-validation branch July 12, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APPLICATIONS show "The Dapr CLI and runtime do not appear to be installed"
3 participants