Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show warning notification when C_Cpp.getIncludes is disabled #12470

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

benmcmorran
Copy link
Member

@benmcmorran benmcmorran commented Jul 12, 2024

Fixes the Copilot issue reported here https://github.com/orgs/community/discussions/131961. We only expect the command to be called by Copilot, so it should be fine to make the warning message less aggressive.

cc @lukka

@benmcmorran benmcmorran force-pushed the dev/bemcmorr/hide-getincludes-notification branch from 63c7c37 to d1234c6 Compare July 12, 2024 17:44
@benmcmorran
Copy link
Member Author

@sean-mcmanus I don't have permission to actually merge this PR. Please merge when you have a chance.

@bobbrow bobbrow merged commit c976dba into main Jul 12, 2024
4 checks passed
@bobbrow bobbrow deleted the dev/bemcmorr/hide-getincludes-notification branch July 12, 2024 17:53
@bobbrow bobbrow restored the dev/bemcmorr/hide-getincludes-notification branch July 12, 2024 17:53
@bobbrow bobbrow deleted the dev/bemcmorr/hide-getincludes-notification branch July 12, 2024 17:53
@benmcmorran benmcmorran restored the dev/bemcmorr/hide-getincludes-notification branch July 12, 2024 18:36
@benmcmorran benmcmorran deleted the dev/bemcmorr/hide-getincludes-notification branch July 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants