-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context to the Copilot Chat #12044
Conversation
5b4dff2
to
47f6624
Compare
fde697c
to
8877030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not actually requesting changes, just blocking the PR until we have approval for the API proposals)
"terminalDataWriteEvent" | ||
"terminalDataWriteEvent", | ||
"chatParticipant", | ||
"chatVariableResolver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need approval to use these APIs before this PR can be approved.
8877030
to
234f064
Compare
- Using ${language}. Prefer a solution written in ${language} to any other language. Call out which language you are using in the answer. | ||
- Using the ${language} standard language version ${standardVersion}. Prefer solutions using the new and more recent features introduced in ${standardVersion}. Call out which standard version you are using in the answer. | ||
- Using the ${compiler} compiler. Prefer solutions supported by the ${compiler} compiler. | ||
- Targeting the ${targetPlatform} platform. Prefer solutions and API that are supported on ${targetPlatform} . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space here -- not sure if that matters though: ${targetPlatform} .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thank you!
234f064
to
57a3f1b
Compare
} | ||
|
||
vscode.chat.registerChatVariableResolver('cpp', | ||
`Describes the the C++ language features that can be used according |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated word "the the"
@lukka Did you want to get these changes into our next release 1.20.2? |
Not yet, thank you for the heads up! |
closing in favor of #12577 |
@benmcmorran @spebl @hnrqbaggio FYI