Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparing explicitly against null #721

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

StephenWeatherford
Copy link
Contributor

This was causing some exceptions in the language server (i.e. a value was undefined but we were checking it against null). It's possible these were caused by the mismatched grammar, but either way this is a bad idea.

@StephenWeatherford StephenWeatherford requested review from a team and PrashanthCorp June 27, 2018 00:33
@StephenWeatherford StephenWeatherford self-assigned this Jun 27, 2018
@StephenWeatherford StephenWeatherford merged commit acbe4d5 into master Jun 27, 2018
@StephenWeatherford StephenWeatherford deleted the saw/null branch June 27, 2018 00:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants