Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace public-ip with our own util to fix CVE-2022-33987 #2048

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Replace public-ip with our own util to fix CVE-2022-33987 #2048

merged 3 commits into from
Jul 11, 2022

Conversation

alexweininger
Copy link
Member

Fixes CVE-2022-33987 by replacing the public-ip package with our own util function.

The util function uses the same methods to get the public IP as the package which are:

  1. DNS via OpenDNS
  2. HTTPS request to public API

@alexweininger alexweininger requested a review from a team as a code owner July 11, 2022 21:02
@alexweininger alexweininger merged commit 61116b6 into main Jul 11, 2022
@alexweininger alexweininger deleted the alex/public-ip branch July 11, 2022 21:16
@microsoft microsoft locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @bwateratmsft