-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Postgres default values to "Basic" #1712
Conversation
family: "Gen5", | ||
size: "102400" | ||
size: "5120" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean 51200
Also, let's make a constant for this since it's used twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size variable takes values in MB and the lowest available size on portal is 5GB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I get why we're picking cheaper options as the default, but do we really need the lowest of the low? 😝 5 GB seems really low to me, and it doesn't even save that much money. If we go that low, I propose we make sure 'storageAutoGrow' is set to 'Enabled'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @fiveisprime @nturinski for your thoughts on storage size and/or auto-grow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nathan and Matt agreed with Eric, let's use the portal's basic default which is 50 GB with auto-grow enabled.
No description provided.