Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Postgres default values to "Basic" #1712

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Conversation

neelip
Copy link
Contributor

@neelip neelip commented Sep 16, 2020

No description provided.

@neelip neelip requested a review from a team as a code owner September 16, 2020 19:04
family: "Gen5",
size: "102400"
size: "5120"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean 51200

Also, let's make a constant for this since it's used twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size variable takes values in MB and the lowest available size on portal is 5GB.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I get why we're picking cheaper options as the default, but do we really need the lowest of the low? 😝 5 GB seems really low to me, and it doesn't even save that much money. If we go that low, I propose we make sure 'storageAutoGrow' is set to 'Enabled'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @fiveisprime @nturinski for your thoughts on storage size and/or auto-grow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nathan and Matt agreed with Eric, let's use the portal's basic default which is 50 GB with auto-grow enabled.

@neelip neelip merged commit e569e16 into master Sep 16, 2020
@neelip neelip deleted the neelima/update-create-values branch September 16, 2020 22:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants