Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ID does not refresh on Explorer #145

Closed
nturinski opened this issue Nov 2, 2017 · 4 comments
Closed

Document ID does not refresh on Explorer #145

nturinski opened this issue Nov 2, 2017 · 4 comments
Labels
bug The issue reveals something not working as expected. future Issues that were in the "future" milestone during our previous triage process P3 ⛔ won't fix The issue is not critical enough to be worked on.

Comments

@nturinski
Copy link
Member

If you rename an id, it does not refresh on the explorer unless you manually refresh it. It should probably refresh itself to update the label on the explorer if the id is changed.
@nturinski nturinski added the bug The issue reveals something not working as expected. label Nov 2, 2017
@ejizba ejizba added this to the 0.3.0 milestone Nov 2, 2017
@ejizba ejizba modified the milestones: 0.3.0, 0.4.0 Dec 11, 2017
@ejizba
Copy link
Contributor

ejizba commented Dec 11, 2017

@nturinski please add more detailed repro steps. I don't believe we support editing the '_id' property at the moment

@PrashanthCorp
Copy link
Contributor

I think it is tied to this issue I talked about. This hasn't gotten much traction though.
In this PR, I still resort to refreshing the node to show the (Connected) sign next to a connected DB.

I would mark this bug as external.

@ejizba ejizba modified the milestones: 0.4.0, 0.5.0 Jan 25, 2018
@ejizba
Copy link
Contributor

ejizba commented Jan 25, 2018

To clarify, you can't change the '_id' filed for a mongo document, so this doesn't apply in that case. However, we should consider fixing for docdb

@ejizba ejizba added the P3 label Feb 8, 2018
@ejizba ejizba modified the milestones: 0.5.0, future Feb 8, 2018
@StephenWeatherford
Copy link
Contributor

This is possible to do, but the work-around is simply to refresh.

@StephenWeatherford StephenWeatherford added the ⛔ won't fix The issue is not critical enough to be worked on. label Mar 21, 2018
PrashanthCorp pushed a commit that referenced this issue Apr 30, 2018
Force refresh a document's tree item post-update. Fixes #145
7ec80b8
@PrashanthCorp PrashanthCorp mentioned this issue May 1, 2018
Merged
PrashanthCorp pushed a commit that referenced this issue May 21, 2018
Force refresh a document's tree item post-update. Fixes #145
ae7e176
PrashanthCorp added a commit that referenced this issue Jun 19, 2018
@PrashanthCorp
Document labels: use fields other than _id wherever possible (#569)
e6fa015 
* Update third party notices for mongodb-extended-json.

* Document labels: use fields other than _id wherever possible

* Remove the number of calls to toString in finding the label

* Force refresh a document's tree item post-update. Fixes #145

* Document labels : make private

* Add setter for tsc -p

* Changes based on feedback

* Based on feedback

* tsc fix

* Feedback + tests

* Add field to documentLabelFields. Kicks off CLA.
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
@ejizba ejizba added the future Issues that were in the "future" milestone during our previous triage process label Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug The issue reveals something not working as expected. future Issues that were in the "future" milestone during our previous triage process P3 ⛔ won't fix The issue is not critical enough to be worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nturinski @StephenWeatherford @ejizba @PrashanthCorp