'Scan for Kits' option to Kits' QuickPick #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to postpone this one temporarily until multi-root is committed since much of this code has moved around and I don't want it to get lost. |
|
Multi-root is committed. Can you merge and resolve conflicts? |
|
I guess more fixes and re-testing will be needed now. |
5ed5b3f to
b9701ff
Compare
Zingam
commented
Jan 22, 2020
| @@ -22,6 +22,14 @@ const localize: nls.LocalizeFunc = nls.loadMessageBundle(); | |||
|
|
|||
| const log = logging.createLogger('kit'); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
@bobbrow I think it makes sense to replace these special kit variables with a enum. Also do we really need to have the type export type scanforkitsKitType = '__scanforkits__';
Please, provide feedback.
There was a problem hiding this comment.
I don't have a strong opinion here.
There was a problem hiding this comment.
Well I did convert these to an enum in my latest commit.
|
I think this is OK now. |
bobbrow
requested changes
Jan 23, 2020
bobbrow
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #864
The following changes are proposed:
The purpose of this change
To enable/remind the user to easily invoke the command Rescan for Kits from the Kits QuickPick.
Other Notes/Information
I had to resubmit this #893 due to a failed merge.