Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally add install target #686

Merged
merged 2 commits into from
May 29, 2019
Merged

conditionally add install target #686

merged 2 commits into from
May 29, 2019

Conversation

andy-held
Copy link

@andy-held andy-held commented May 16, 2019

This change addresses item #504

closes #504

This changes visible behavior

The following changes are proposed:

Conditionally add an install meta target if there is a project that has an install rule.

The purpose of this change

cmake-server does not give an install target in project targets.

@andy-held
Copy link
Author

andy-held commented May 16, 2019

Hm, this will not work with CMake versions prior to 3.11 because projects did not have the hasInstallRule field then, c.f. https://cmake.org/cmake/help/v3.10/manual/cmake-server.7.html

@andy-held
Copy link
Author

This seems to have passed the tests, but I actually expect it to not work with CMake 3.10 and lower due to the missing field.

@yeganer
Copy link

yeganer commented May 22, 2019

This is awesome.

Looking at the response from the CMake server, individual targets also have the hasInstallRule property. One could use that to generate install rules for individual targets.
This would be very useful in a scenario where running the full install produces errors but the install of individual components (which are currently being developed) is possible.

Andreas Franek added 2 commits May 23, 2019 15:47
… target in project targets.Hence, we add one if there is a project with an install rule.closes #504
@KoeMai KoeMai merged commit 106c05c into microsoft:develop May 29, 2019
@andy-held andy-held deleted the bugfix/install-target branch May 31, 2019 11:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target install missing
3 participants