Support usage of environment variables for toolchainFile in kits #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Now with everything building and tests passing
…Fix strange whitespace in kit.ts
|
Why has this not been reviewed yet? I think this is a major issue. Android's NDK includes a CMake toolchain file with it, but all developers install the NDK to different locations. Hence it's important to be able to do something like this: @vector-of-bool Can you provide some feedback? |
no-realm
reviewed
Apr 3, 2019
| export function processKit(kit: Kit) { | ||
| if (kit.toolchainFile) { | ||
| // map ${foo} -> process.env[foo] to resolve corresponding environment variables | ||
| kit.toolchainFile = kit.toolchainFile.replace(/\$\{(\w+)\}/, (_str: string, p1: string, ..._args) => { |
There was a problem hiding this comment.
Have you checked whether case sensitivity is an issue here?
This here might be useful: https://github.com/vector-of-bool/vscode-cmake-tools/blob/develop/src/expand.ts
|
This PR was replaced by #991. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes kit handling to support environment variables (${SOME_ENV_VAR} pattern) for toolchainFile setting
The following changes are proposed:
The purpose of this change
Scratching one of my itches using this extension. I wanted to use an env var to specify where my vcpkg toolchain is installed, rather than hardcode it. This does what I want, but feel free to suggest a better way if you can think of one.