Fix configure preset used in workflow preset defined in CMakeUserPresets.json #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when workflow preset in CMakeUserPresets.json references configure preset that is also defined in CMakeUserPresets.json, this extension reports an error that the configure preset can't be found. And that results in the CMakeUserPresets.json getting ignored along with all presets defined in it. This commits fixes this problem by adding a lookup from userConfigurePresets in case the configure preset isn't found in configurePresets.
gcampbell-msft
previously approved these changes
Dec 9, 2024
|
@nikobockerman Approved, but can you also add a CHANGELOG.md update? |
…eset-in-user-presets
|
@microsoft-github-policy-service agree |
gcampbell-msft
approved these changes
Dec 10, 2024
hippo91
pushed a commit
to hippo91/vscode-cmake-tools
that referenced
this pull request
Dec 21, 2024
…ets.json (microsoft#4202) * Fix workflow preset configure in user presets Previously, when workflow preset in CMakeUserPresets.json references configure preset that is also defined in CMakeUserPresets.json, this extension reports an error that the configure preset can't be found. And that results in the CMakeUserPresets.json getting ignored along with all presets defined in it. This commits fixes this problem by adding a lookup from userConfigurePresets in case the configure preset isn't found in configurePresets. * Add CHANGELOG entry --------- Co-authored-by: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com>
|
Verified this issue on cmake tools v1.20.50(pre-release) & v1.20.52(release), issue was fixed. We can find the configure preset and workflow preset when workflow preset in CMakeUserPresets.json references configure preset that is also defined in CMakeUserPresets.json. Please see following recording: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when workflow preset in CMakeUserPresets.json references configure preset that is also defined in CMakeUserPresets.json, this extension reports an error that the configure preset can't be found.
And that results in the CMakeUserPresets.json getting ignored along with all presets defined in it.
This commits fixes this problem by adding a lookup from userConfigurePresets in case the configure preset isn't found in configurePresets.