Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remvove extra postWorkspaceOpen #2990

Merged
merged 4 commits into from
Feb 1, 2023
Merged

remvove extra postWorkspaceOpen #2990

merged 4 commits into from
Feb 1, 2023

Conversation

elahehrashedi
Copy link
Contributor

@elahehrashedi elahehrashedi commented Jan 31, 2023 •
edited
Loading

await this.projectController.loadAllProjects() already calls postWorkspaceOpen on every project
bugfix: #2989

@elahehrashedi elahehrashedi marked this pull request as ready for review January 31, 2023 22:34
@elahehrashedi elahehrashedi requested a review from bobbrow January 31, 2023 22:34
sean-mcmanus
sean-mcmanus reviewed Jan 31, 2023
View reviewed changes
@elahehrashedi elahehrashedi enabled auto-merge (squash) February 1, 2023 18:02
@elahehrashedi elahehrashedi merged commit 82e5e59 into main Feb 1, 2023
@elahehrashedi elahehrashedi deleted the elrashed/extraPostWorkspaceOpen branch February 1, 2023 18:33
elahehrashedi added a commit that referenced this pull request Feb 1, 2023
@elahehrashedi
remvove extra postWorkspaceOpen (#2990)
ae73e8a
@bobbrow bobbrow added this to the 1.13 patches milestone Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow approved these changes

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13 patches
Development

Successfully merging this pull request may close these issues.
3 participants
@elahehrashedi @bobbrow @sean-mcmanus