Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"build" task improvements #2938

Merged
merged 5 commits into from
Jan 12, 2023
Merged

"build" task improvements #2938

merged 5 commits into from
Jan 12, 2023

Conversation

piomis
Copy link
Contributor

@piomis piomis commented Jan 10, 2023

This change addresses item #2935

Fixes #2935

This changes how build tasks are selected when "useBuild" option is used and some tasks are defined in tasks.json file

The following changes are proposed:

  • while filtering tasks from tasks.json to get only "build" tasks type compare TaskGroup.id instead of complete object
  • use isDefault property from temporary created tasks instead of group of this task

Other Notes/Information

See #2780 comment: #2780 (comment)

@elahehrashedi elahehrashedi self-requested a review January 12, 2023 15:26
@elahehrashedi elahehrashedi changed the title Comparison of Build type tasks for ones with "isDefault" option set "build" task improvements Jan 12, 2023
@elahehrashedi elahehrashedi mentioned this pull request Jan 12, 2023
Closed
@piomis piomis mentioned this pull request Jan 12, 2023
Closed
@bobbrow bobbrow added this to the 1.13 milestone Jan 12, 2023
@elahehrashedi elahehrashedi enabled auto-merge (squash) January 12, 2023 19:06
@elahehrashedi elahehrashedi merged commit 4ccb03c into microsoft:main Jan 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow approved these changes

@elahehrashedi elahehrashedi Awaiting requested review from elahehrashedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.

"build" task improvements
3 participants
@piomis @bobbrow @elahehrashedi