Revise effectiveKitEnvironment to fixes #2354 and #2364 #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Feb 7, 2022
bobbrow
reviewed
Feb 7, 2022
src/kit.ts
Outdated
| } | ||
| } | ||
| log.debug(localize('kit.env', 'The environment variables for kit {0} is: {1}', `'${kit.name}'`, JSON.stringify(env))); |
There was a problem hiding this comment.
suggestion: 'The environment for kit {0}: {1}'
|
@bobbrow Can you help me, why the CI are failed? |
bobbrow
reviewed
Feb 8, 2022
I'm not sure, but it's not your fault. Other PR's all seem to be hitting this suddenly. Our most recent commits were clean. We'll take a look. |
bobbrow
approved these changes
Feb 15, 2022
…2364 Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2354 and #2364
Signed-off-by: Yonggang Luo luoyonggang@gmail.com