Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intellisense and launch when using multi config generators in presets #2130

Conversation

xisui-MSFT
Copy link
Collaborator

This change addresses item #2099

Using CMAKE_CONFIGURATION_TYPES to determine if a multi config generator is used.

When a multi config generator is used, the actual "build type" is determined by --config argument in cmake --build command, or configuration field in build presets. Therefore use it as the "build type" or "configuration" when using multi config generators, and update code model when switching build presets.

@bobbrow bobbrow added this to the 1.9.0 milestone Sep 20, 2021
@bobbrow bobbrow requested a review from a team September 20, 2021 17:18
@andreeis andreeis merged commit 2bf7741 into microsoft:develop Sep 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants