utils: Handle showInputBox errors that could be thrown during valid…

…ation (#1879)
microsoft · Jan 30, 2025 · 012787d · 012787d
1 parent 8eec250
commit 012787d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/utils/package-lock.json b/utils/package-lock.json
diff --git a/utils/package.json b/utils/package.json
@@ -1,7 +1,7 @@
 {
     "name": "@microsoft/vscode-azext-utils",
     "author": "Microsoft Corporation",
-    "version": "2.5.12",
+    "version": "2.5.13",
     "description": "Common UI tools for developing Azure extensions for VS Code",
     "tags": [
         "azure",

diff --git a/utils/src/userInput/showInputBox.ts b/utils/src/userInput/showInputBox.ts
@@ -7,6 +7,7 @@ import { Disposable, InputBox, InputBoxOptions, QuickInputButton, QuickInputButt
 import * as types from '../../index';
 import { AzExtQuickInputButtons } from '../constants';
 import { GoBackError, UserCancelledError } from '../errors';
+import { parseError } from '../parseError';
 import { validOnTimeoutOrException } from '../utils/inputValidation';
 import { nonNullProp } from '../utils/nonNull';
 import { openUrl } from '../utils/openUrl';
@@ -38,14 +39,19 @@ export async function showInputBox(context: IInternalActionContext, options: typ
                     inputBox.enabled = false;
                     inputBox.busy = true;
 
-                    const validateInputResult: InputBoxValidationResult = await latestValidation;
-                    const asyncValidationResult: string | undefined | null = options.asyncValidationTask ? await options.asyncValidationTask(inputBox.value) : undefined;
-                    if (!validateInputResult && !asyncValidationResult) {
-                        resolve(inputBox.value);
-                    } else if (validateInputResult) {
-                        inputBox.validationMessage = validateInputResult;
-                    } else if (asyncValidationResult) {
-                        inputBox.validationMessage = asyncValidationResult;
+                    try {
+                        const validateInputResult: InputBoxValidationResult = await latestValidation;
+                        const asyncValidationResult: string | undefined | null = options.asyncValidationTask ? await options.asyncValidationTask(inputBox.value) : undefined;
+                        if (!validateInputResult && !asyncValidationResult) {
+                            resolve(inputBox.value);
+                        } else if (validateInputResult) {
+                            inputBox.validationMessage = validateInputResult;
+                        } else if (asyncValidationResult) {
+                            inputBox.validationMessage = asyncValidationResult;
+                        }
+                    } catch (e) {
+                        const pe: types.IParsedError = parseError(e);
+                        reject(pe.message);
                     }
 
                     inputBox.enabled = true;