Fix for when SiteClient constructor throws ArgumentError; #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
approved these changes
Mar 28, 2018
|
@EricJizbaMSFT I had looked into maybe trying to get it to still return a result... that looks like it would be part of the https://github.com/Microsoft/vscode-azuretools as opposed to this one (possibly). I'll look into submitting a PR there as well so that we can display them in the list (maybe with a flag or label next to it of some sort indicating there was a problem). |
|
Yes it would be a part of that repo |
Flanker32
pushed a commit
to Flanker32/vscode-azureappservice
that referenced
this pull request
Apr 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #371