Add an overload to SwitchToMainThreadAsync that exposes 'alwaysYield' #340
Conversation
3cf348a to
e9fe7a7
Compare
| /// await TaskScheduler.Default; | ||
| /// | ||
| /// // Now switch to the Main thread to talk to some STA object. | ||
| /// await this.JobContext.SwitchToMainThreadAsync(alwaysYield: true); |
There was a problem hiding this comment.
This sample isn't particularly compelling because it will always yield anyway. Can you include a sample that demonstrates when it would be interesting to use this overload? (at least that's already on the main thread or in an ambiguous state)?
There was a problem hiding this comment.
💭 A compelling example would be great. I actually prefer to not use this in favor of either alwaysYield: false (default behavior) or Task.Yield (always yield, but stay on current thread). This method's primary advantage is supporting the incremental conversion of code using SynchronizationContext.Post or other "always yield" methods to vs-threading.
There was a problem hiding this comment.
I've updated the sample. Since I don't have permission to push to your source branch, I'll complete the PR with my commit on top locally.
Add an overload to SwitchToMainThreadAsync that exposes 'alwaysYield'
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #326