Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folly/fizz]Upgrade version. #8765

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 28, 2019

Needed by port proxygen(#8766).

Note: all features test pass with following triples:

  • x64-windows (only support x64)
  • x64-windows-static (only support x64)

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 28, 2019
@JackBoosY JackBoosY requested a review from PhoebeHui October 28, 2019 06:38
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 28, 2019

json.cpp(142): error C2061: syntax error: identifier 'ref'

using ref = std::reference_wrapper<decltype(o.items())::value_type const>;

I cannot repro it, even in Visual Studio 2019, seems like a compiler bug and already fixed in Visual Studio 2019.

@JackBoosY JackBoosY marked this pull request as ready for review October 28, 2019 07:23
@PhoebeHui
Copy link
Contributor

Double checked, it's a compiler bug that already fixed in vs2019 16.4 preview 2.

The failures:
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(142): error C2061: syntax error: identifier 'ref'
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(145): note: see reference to function template instantiation 'auto folly::json::`anonymous-namespace'::Printer::printObject::<lambda_1>::operator ()<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,folly::Function<bool (const folly::dynamic &,const folly::dynamic &) const>>(_T1,_T2,const _T3 &) const' being compiled
with
[
_Ty=ref,
_T1=std::_Vector_iterator<std::_Vector_val<std::_Simple_types>>,
_T2=std::_Vector_iterator<std::_Vector_val<std::_Simple_types>>,
_T3=folly::Function<bool (const folly::dynamic &,const folly::dynamic &) const>
]
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly/Range.h(1356): note: see reference to class template instantiation 'folly::Range<const char *>' being compiled
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(140): error C2065: 'a': undeclared identifier
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(140): error C2065: 'b': undeclared identifier
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(140): error C2064: term does not evaluate to a function taking 1 arguments
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(142): note: class does not define an 'operator()' or a user defined conversion operator to a pointer-to-function or reference-to-function that takes appropriate number of arguments
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(140): error C2672: 'operator __surrogate_func': no matching overloaded function found
E:\VCPKG\jack\vcpkg\buildtrees\folly\src\46d6707604-d64234cbb5\folly\json.cpp(142): error C2780: 'unknown-type std::less::operator ()(_Ty1 &&,_Ty2 &&) noexcept() const': expects 2 arguments - 1 provided
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\xstddef(242): note: see declaration of 'std::less::operator ()'

JackBoosY pushed a commit to ras0219-msft/vcpkg that referenced this pull request Oct 30, 2019
@JackBoosY
Copy link
Contributor Author

@vicroms I think this pr is ready to merge now.

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

@dan-shaw Ready to merge now.

@dan-shaw dan-shaw merged commit 232c203 into microsoft:master Nov 22, 2019
@JackBoosY JackBoosY deleted the dev/jack/upgrade_fizz_folly branch November 22, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants