Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[curl]Fix tools depends zlib. #8739

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[curl]Fix tools depends zlib. #8739

merged 1 commit into from
Oct 25, 2019

Conversation

JackBoosY
Copy link
Contributor

Related: #8733.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 25, 2019
@JackBoosY JackBoosY requested a review from PhoebeHui October 25, 2019 06:18
@JackBoosY
Copy link
Contributor Author

@phoyd Could you test it? Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review October 25, 2019 09:26
@phoyd
Copy link

phoyd commented Oct 25, 2019 •
edited
Loading

@phoyd Could you test it? Thanks.

dev/jack/8733 works for me. Thanks.

$ ./curl -V
curl 7.66.0-DEV (Linux) libcurl/7.66.0-DEV OpenSSL/1.0.2s zlib/1.2.11 libssh2/1.9.0_DEV
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp

@ras0219-msft ras0219-msft merged commit d3a7830 into microsoft:master Oct 25, 2019
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR and verification!

@JackBoosY JackBoosY deleted the dev/jack/8733 branch October 28, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

Assignees
No one assigned
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @phoyd @ras0219-msft