-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cgal][openmvs] CGAL: Upgrade to 5.0 #8659
Conversation
This pull-request is for the moment a draft. Do not merge it until it is updated to 5.0 final version. |
Could you add a Lines 1 to 4 in 2aaf7fd
vcpkg/ports/date/portfile.cmake Lines 44 to 45 in 2aaf7fd
That would avoid the false message displayed automatically by vcpkg:
|
I have pushed an upgrade to CGAL-5.0-beta2. That is still a |
I have upgraded to 5.0. This PR should now be ready for integration. |
This is a really important library for my project. I have tests for MacOS, Linux, and Windows if you want real-world examples to check: https://github.com/acgetchell/CDT-plusplus |
I don't understand the CI failures. It says it is probably caused by the missing log files for comparison baseline, but I don't know how to fix this :/ |
@maxGimeno See #8949. |
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR LGTM except that openmvs
needs to have its control version incremented to include the new patch file.
@maxGimeno Please modify VCPKG_PATH/ports/openmvs/CONTROL: |
@ras0219-msft I thinks this PR is ready to merge now. |
Thanks for the PR! |
Thank you, that was a smooth upgrade and the first simultaneous one for me on Windows, Linux, and macOS. https://ci.appveyor.com/project/acgetchell/cdt-plusplus#L518 https://travis-ci.org/acgetchell/CDT-plusplus/jobs/615752586#L540 |
Upgrade the CGAL port to version 5.0-beta1