Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcl]Upgrade to 8.6.9 and use vcpkg_install_make/vcpkg_install_nmake. #8402

Merged
merged 5 commits into from
Oct 18, 2019
Merged

[tcl]Upgrade to 8.6.9 and use vcpkg_install_make/vcpkg_install_nmake. #8402

merged 5 commits into from
Oct 18, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 30, 2019 •
edited
Loading

  1. Switch to vcpkg_install_make/vcpkg_install_nmake
  2. Upgrade to v8.6.9

Need to wait #8489 merge and merge.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Sep 30, 2019
@JackBoosY JackBoosY mentioned this pull request Sep 30, 2019
Merged
9 tasks
cbezault
cbezault suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@cbezault cbezault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this is actually going to be a downgrade (but I'm okay with that). I'm pretty sure the PR I merged had a dev version of Tcl.

ports/tcl/portfile.cmake Outdated Show resolved Hide resolved
@MVoz
Copy link
Contributor

MVoz commented Oct 1, 2019

opt static,msvcrt

@cbezault
Copy link
Contributor

cbezault commented Oct 5, 2019

@voskrese sorry it's not clear what you mean and I'd like to see this PR merged.

@MVoz
Copy link
Contributor

MVoz commented Oct 5, 2019 •
edited
Loading

@cbezault
Build the static core and shell + add
OPTS=static,msvcrt

only core OPTS=static

https://github.com/tcltk/tcl/blob/db5724895859981b0652052eb14fe9290539355c/win/buildall.vc.bat#L71

@JackBoosY
Copy link
Contributor Author

@voskrese Using msvcrt will change crt linkage to dynamic, while crt linkage when building static libraries should be static.
And when static build, no matter whether I build debug or release will generate debug library, I don't know how to deal with this problem.

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY marked this pull request as ready for review October 15, 2019 04:50
@dan-shaw dan-shaw merged commit db411cb into microsoft:master Oct 18, 2019
@JackBoosY JackBoosY deleted the dev/jack/tcl_use_make branch October 18, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbezault cbezault cbezault requested changes

Assignees

@dan-shaw dan-shaw

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @MVoz @cbezault @dan-shaw