Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Added documentation page for vcpkg_fixup_cmake_targets.cmake #8365

Merged

Conversation

vpaladino778
Copy link
Contributor

Added example usage comment to .cmake file. I found it somewhat confusing with the way the comment was formatted, so i changed it for clarity. Also added a basic documentation page for vcpkg_fixup_cmake_targets.cmake

@vpaladino778 vpaladino778 changed the title Added documentation page for vcpkg_fixup_cmake_targets.cmake [Documentation] Added documentation page for vcpkg_fixup_cmake_targets.cmake Sep 26, 2019
@vicroms vicroms self-assigned this Sep 26, 2019
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbezault
Copy link
Contributor

/azp run

@vpaladino778
Copy link
Contributor Author

I'm trying to figure out why @cbezault's commits caused the build to fail, because my original commit passed the tests. The weird thing is that all he changes was some comments.

@vpaladino778
Copy link
Contributor Author

Here was the errors from the failed checks:

##[error] REGRESSION: librabbitmq:x64-linux
##[error] REGRESSION: geographiclib:x64-linux
##[error] REGRESSION: otl:x64-linux

After checking out the master branch, and attempting to compile geographiclib and otl, I recieved errors. So this problem may not be with these commits, but a problem with the master branch.

@cbezault
Copy link
Contributor

cbezault commented Sep 30, 2019

I'm pretty sure otl's hash changed on us, which is why it's failing :/.
Ideally we would clean up all these failures in other PRs and then merge this one.

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8365 in repo microsoft/vcpkg

@vpaladino778 vpaladino778 requested a review from vicroms October 1, 2019 13:00
@cbezault cbezault merged commit 5ebf656 into microsoft:master Oct 1, 2019
@vpaladino778 vpaladino778 deleted the fixup_cmake_targets-documentation branch October 1, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants