[sdl1] fix windows sdk 18362 build failure #8327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding macro definition to silence new compile time diagnostics from updated windows SDK. This is not expected to change the behavior, only supress a new diagnostic that is warning about existing behavior.
|
/azp run |
|
Should we give an official report? |
|
@JackBoosY we probably should at least point it out, although the SDL2 port does not have the same issue so it is likely they were aware and fixed it in the latest version and may not back port it to this earlier version of SDL. |
|
It seems that this issue is not resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding macro definition to silence new compile time diagnostics from
updated windows SDK. This is not expected to change the behavior, only
supress a new diagnostic that is warning about existing behavior.