[libpng] Replace find_library() with a simple set() for linking libm on UNIX #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change looks good to me. Could you also bump the version in the |
|
Done, is now 1.6.37-4. |
Rastaban
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar issue as with Pull Request #7989, but different and more generic fix. Linking libm will work with the default x64-linux triplet, but fail if cross compiling (with a user-specific x86-linux triplet for example), with or without emscripten. As libm is part of the standard library, it can just be linked with its name.
This issue was also present in the Conan package manager and fixed the same way.